reduce config items #978
reduce config items #978
Conversation
Signed-off-by: lucklove <gnu.crazier@gmail.com>
zhouqiang-cl
requested review from
zz-jason,
jackysp,
zhangjinpeng87,
AndreMouche,
nolouch and
ericsyh
|
|
||
| # Pseudo stats will be used if the ratio between the modify count and | ||
| # row count in statistics of a table is greater than it. | ||
| # pseudo-estimate-ratio: 0.8 |
There was a problem hiding this comment.
It's better to keep them in the config files:
run-auto-analyze
feedback-probability
query-feedback-limit
pseudo-estimate-ratio
There was a problem hiding this comment.
https://docs.google.com/spreadsheets/d/1fmY3MSklHb9jYQOv3Djcrhj3Uz97fI06soaMy4OKcRs/edit#gid=0
PM think they should not be visible to user
| # Queries with execution time greater than this value will be logged. (Milliseconds) | ||
| # slow-threshold: 300 | ||
|
|
||
| # Queries with internal result greater than this value will be logged. | ||
| # expensive-threshold: 10000 | ||
|
|
||
| # Maximum query length recorded in log. |
There was a problem hiding this comment.
Could we confirm that all the removed items is mentioned in documents?
Signed-off-by: lucklove <gnu.crazier@gmail.com>
This reverts commit 1043c3d.
This reverts commit 1043c3d.
| # info-log-dir: "" | ||
|
|
||
| ## Options for "Titan" | ||
| titan: |
There was a problem hiding this comment.
why remove this? 🤣can you add it back?
There was a problem hiding this comment.
All config items which been reduced have been added back.
There was a problem hiding this comment.
didn't see it in v3.0.7 and master
There was a problem hiding this comment.
Update, added back in 3.0 and 3.1, master did not add. The released version can't be added back.
There was a problem hiding this comment.
Can we also revert the change for titan in master?
Signed-off-by: lucklove gnu.crazier@gmail.com